Update builder to consider package constraints when skipping binaries (grpc fix)#311
Conversation
allenporter
force-pushed
the
builder-constraints
branch
from
bdf9bca to
0ffa682
Compare
|
@frenck This is required before we do attempt #3. My impression is we'll also need a release of wheels, and need to update https://github.com/home-assistant/core/blob/dev/.github/workflows/wheels.yml in core to use this. |
|
Thanks.
|
You can bump it. |
Bump wheels to 2021.01.0 to pick up home-assistant/wheels#311 for issue home-assistant#56669
|
Great, once a new release is made i'll send the PR to update -- i have it ready to go, and ready to exercise one last attempt this week to bump grpcio. |
|
Hi, Can one of you make a wheels release? My impression is I don't have permission to do that. |
|
We can't as the build are failing as it seems.
Probably related to 2b30160 |
|
ok.... I've sent #315 to revert? |
|
Yes, discussed it last night with Pascal and others. That is OK to revert, after that we can move forward |
4 participants
Update wheel builder to consider package constraints when skipping binaries.
The basic idea is to ensure that --skip-binary can reference packages that are not explicit requirements to always force grpc to be built from source.
Reviewer note: An alternative could be to add grpcio to be an explicit requirement for an integration (e.g. nest/pubsub/google, etc)
For home-assistant/core#56669